Skip to content

If PR stats table is first item in the PR, the "already published" check fails #7

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
derek-young opened this issue Jul 23, 2021 · 3 comments

Comments

@derek-young
Copy link
Contributor

If there is no other content in the PR body, the check in alreadyPublished.js returns false instead of true, and two tables get published to the PR description. I believe this is because the regex is prefixed with a new line character, so if there is not a line above the table, it returns false: const regexp = new RegExp(\n(${TABLE_TITLE})\n);. Unfortunately, I don't have time for a PR now, but wanted to open the issue so it wasn't lost! Thanks Manuel

@manuelmhtr
Copy link
Contributor

Ohh great finding! Thanks @derek-young
No problem, I'll send the fix as soon as possible.

@manuelmhtr
Copy link
Contributor

Fixed in v2.0.3

@manuelmhtr
Copy link
Contributor

Hi @derek-young we forgot to build the changes (yarn build) LOL.
Now they are published in v2.1.0

Just in case you still had problems with the action.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants