Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: print progress estimation improvements #1414

Merged
merged 2 commits into from
Apr 13, 2024
Merged

feat: print progress estimation improvements #1414

merged 2 commits into from
Apr 13, 2024

Conversation

pedrolamas
Copy link
Member

  • Restores the filament estimation calculation code
  • Allows selection of absolute file position progress (virtual_sdcard.progress from Klipper)
  • If relative file position progress selected and not available, fallback to virtual_sdcard.progress

@pedrolamas
feat: print progress estimation improvements
5abab3c 
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas added the FR - Enhancement New feature or request label Apr 13, 2024
@pedrolamas pedrolamas added this to the 1.29.2 milestone Apr 13, 2024
@pedrolamas pedrolamas requested a review from matmen April 13, 2024 16:40
matmen
matmen requested changes Apr 13, 2024
View reviewed changes
src/store/printer/getters.ts Outdated Show resolved Hide resolved
@pedrolamas
fix: filament print progress
11265b4 
Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas merged commit 8ad71bc into fluidd-core:develop Apr 13, 2024
4 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/print-progress-improvements branch April 13, 2024 17:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matmen matmen matmen approved these changes

Assignees
No one assigned
Labels
FR - Enhancement New feature or request
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.
2 participants
@pedrolamas @matmen