Skip to content

Commit 80a71da

Browse files
authored
Disable two lint rules which are being removed. (#8488)
Each of these are going to be removed soon. * avoid_null_checks_in_equality_operators * unsafe_html Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
1 parent 3b73a65 commit 80a71da

File tree

3 files changed

+0
-4
lines changed

3 files changed

+0
-4
lines changed

packages/analysis_options.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ linter:
4343
- avoid_function_literals_in_foreach_calls
4444
- avoid_init_to_null
4545
# - avoid_js_rounded_ints # only useful when targeting JS runtime
46-
- avoid_null_checks_in_equality_operators
4746
# - avoid_positional_boolean_parameters # not yet tested
4847
- avoid_print
4948
# - avoid_private_typedef_functions # we prefer having typedef (discussion in https://github.com/flutter/flutter/pull/16356)
@@ -138,7 +137,6 @@ linter:
138137
- unnecessary_statements
139138
- unnecessary_this
140139
- unrelated_type_equality_checks
141-
- unsafe_html
142140
- use_rethrow_when_possible
143141
# - use_setters_to_change_properties # not yet tested
144142
# - use_string_buffers # https://github.com/dart-lang/linter/pull/664

packages/devtools_app/lib/src/extensions/embedded/_controller_web.dart

-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ class EmbeddedExtensionControllerImpl extends EmbeddedExtensionController
8787
_extensionIFrame = HTMLIFrameElement()
8888
// This url is safe because we built it ourselves and it does not include
8989
// any user input.
90-
// ignore: unsafe_html
9190
..src = extensionUrl
9291
..allow = 'usb';
9392
_extensionIFrame.style

packages/devtools_app/lib/src/screens/performance/panes/timeline_events/perfetto/_perfetto_controller_web.dart

-1
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,6 @@ class PerfettoControllerImpl extends PerfettoController {
167167
_perfettoIFrame = HTMLIFrameElement()
168168
// This url is safe because we built it ourselves and it does not include
169169
// any user input.
170-
// ignore: unsafe_html
171170
..src = perfettoUrl
172171
..allow = 'usb';
173172
_perfettoIFrame.style

0 commit comments

Comments
 (0)