From 943ffbc62fc9cf9af1ff4159c0c07b5392dcf4f3 Mon Sep 17 00:00:00 2001 From: Preston Schwartz Date: Sun, 19 Feb 2023 16:08:22 -0600 Subject: [PATCH] [plugins] Disables the AndroidGradlePluginVersion issue ID in all android packages (#7045) * Disables the AndroidGradlePluginVersion issue ID in all android packages. * Reverted changelog changes * Reverted all changelog changes. * Fixes changelog conflicts across android packages. --------- Co-authored-by: Stuart Morgan --- packages/camera/camera_android/android/build.gradle | 5 +---- packages/espresso/android/build.gradle | 5 +---- .../flutter_plugin_android_lifecycle/android/build.gradle | 5 +---- .../google_maps_flutter_android/android/build.gradle | 5 +---- .../google_sign_in_android/android/build.gradle | 5 +---- .../image_picker/image_picker_android/android/build.gradle | 4 +--- .../in_app_purchase_android/android/build.gradle | 5 +---- packages/local_auth/local_auth_android/android/build.gradle | 5 +---- .../path_provider/path_provider_android/android/build.gradle | 5 +---- .../quick_actions/quick_actions_android/android/build.gradle | 5 +---- .../shared_preferences_android/android/build.gradle | 4 +--- .../url_launcher/url_launcher_android/android/build.gradle | 4 +--- .../video_player/video_player_android/android/build.gradle | 4 +--- .../webview_flutter_android/android/build.gradle | 4 +--- 14 files changed, 14 insertions(+), 51 deletions(-) diff --git a/packages/camera/camera_android/android/build.gradle b/packages/camera/camera_android/android/build.gradle index 7ed8ac77d371..9c403e02bbd4 100644 --- a/packages/camera/camera_android/android/build.gradle +++ b/packages/camera/camera_android/android/build.gradle @@ -35,10 +35,7 @@ android { testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } lintOptions { - // TODO(stuartmorgan): Enable when gradle is updated. - // disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' baseline file("lint-baseline.xml") } compileOptions { diff --git a/packages/espresso/android/build.gradle b/packages/espresso/android/build.gradle index 47a81b6eea27..6a64f66fc1e7 100644 --- a/packages/espresso/android/build.gradle +++ b/packages/espresso/android/build.gradle @@ -29,10 +29,7 @@ android { testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } lintOptions { - // TODO(stuartmorgan): Enable when gradle is updated. - // disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' baseline file("lint-baseline.xml") } diff --git a/packages/flutter_plugin_android_lifecycle/android/build.gradle b/packages/flutter_plugin_android_lifecycle/android/build.gradle index ae7e518b69da..62c603262989 100644 --- a/packages/flutter_plugin_android_lifecycle/android/build.gradle +++ b/packages/flutter_plugin_android_lifecycle/android/build.gradle @@ -30,10 +30,7 @@ android { consumerProguardFiles 'proguard.txt' } lintOptions { - // TODO(stuartmorgan): Enable when gradle is updated. - // disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' } dependencies { diff --git a/packages/google_maps_flutter/google_maps_flutter_android/android/build.gradle b/packages/google_maps_flutter/google_maps_flutter_android/android/build.gradle index 79486a2716a2..6f8d3060a9cf 100644 --- a/packages/google_maps_flutter/google_maps_flutter_android/android/build.gradle +++ b/packages/google_maps_flutter/google_maps_flutter_android/android/build.gradle @@ -29,10 +29,7 @@ android { testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } lintOptions { - // TODO(stuartmorgan): Enable when gradle is updated. - // disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' } dependencies { diff --git a/packages/google_sign_in/google_sign_in_android/android/build.gradle b/packages/google_sign_in/google_sign_in_android/android/build.gradle index 9bc00197e03b..21b7fa178c8f 100644 --- a/packages/google_sign_in/google_sign_in_android/android/build.gradle +++ b/packages/google_sign_in/google_sign_in_android/android/build.gradle @@ -29,10 +29,7 @@ android { testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } lintOptions { - // TODO(stuartmorgan): Enable when gradle is updated. - // disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' } diff --git a/packages/image_picker/image_picker_android/android/build.gradle b/packages/image_picker/image_picker_android/android/build.gradle index 145ee96ca19e..e61f3161d0f5 100644 --- a/packages/image_picker/image_picker_android/android/build.gradle +++ b/packages/image_picker/image_picker_android/android/build.gradle @@ -29,9 +29,7 @@ android { testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } lintOptions { - disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' } dependencies { implementation 'androidx.core:core:1.8.0' diff --git a/packages/in_app_purchase/in_app_purchase_android/android/build.gradle b/packages/in_app_purchase/in_app_purchase_android/android/build.gradle index fe9a958580ba..0d4bde6183cd 100644 --- a/packages/in_app_purchase/in_app_purchase_android/android/build.gradle +++ b/packages/in_app_purchase/in_app_purchase_android/android/build.gradle @@ -29,10 +29,7 @@ android { testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } lintOptions { - // TODO(stuartmorgan): Enable when gradle is updated. - // disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' } compileOptions { sourceCompatibility JavaVersion.VERSION_1_8 diff --git a/packages/local_auth/local_auth_android/android/build.gradle b/packages/local_auth/local_auth_android/android/build.gradle index c3ae48a65735..8e116709d6cc 100644 --- a/packages/local_auth/local_auth_android/android/build.gradle +++ b/packages/local_auth/local_auth_android/android/build.gradle @@ -29,10 +29,7 @@ android { testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } lintOptions { - // TODO(stuartmorgan): Enable when gradle is updated. - // disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' baseline file("lint-baseline.xml") } diff --git a/packages/path_provider/path_provider_android/android/build.gradle b/packages/path_provider/path_provider_android/android/build.gradle index c525cd388f5a..926142e5eaf8 100644 --- a/packages/path_provider/path_provider_android/android/build.gradle +++ b/packages/path_provider/path_provider_android/android/build.gradle @@ -29,10 +29,7 @@ android { testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } lintOptions { - // TODO(stuartmorgan): Enable when gradle is updated. - // disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' } compileOptions { sourceCompatibility JavaVersion.VERSION_1_8 diff --git a/packages/quick_actions/quick_actions_android/android/build.gradle b/packages/quick_actions/quick_actions_android/android/build.gradle index e096e907ab70..4291fa020ef9 100644 --- a/packages/quick_actions/quick_actions_android/android/build.gradle +++ b/packages/quick_actions/quick_actions_android/android/build.gradle @@ -29,10 +29,7 @@ android { testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } lintOptions { - // TODO(stuartmorgan): Enable when gradle is updated. - // disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' } dependencies { diff --git a/packages/shared_preferences/shared_preferences_android/android/build.gradle b/packages/shared_preferences/shared_preferences_android/android/build.gradle index 480e815d06f1..29f946bf7f77 100644 --- a/packages/shared_preferences/shared_preferences_android/android/build.gradle +++ b/packages/shared_preferences/shared_preferences_android/android/build.gradle @@ -37,9 +37,7 @@ android { testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } lintOptions { - disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' baseline file("lint-baseline.xml") } dependencies { diff --git a/packages/url_launcher/url_launcher_android/android/build.gradle b/packages/url_launcher/url_launcher_android/android/build.gradle index b3d103c32081..63d81249ed8e 100644 --- a/packages/url_launcher/url_launcher_android/android/build.gradle +++ b/packages/url_launcher/url_launcher_android/android/build.gradle @@ -29,9 +29,7 @@ android { testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } lintOptions { - disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' } diff --git a/packages/video_player/video_player_android/android/build.gradle b/packages/video_player/video_player_android/android/build.gradle index daf3b8f4b83e..903ee219d881 100644 --- a/packages/video_player/video_player_android/android/build.gradle +++ b/packages/video_player/video_player_android/android/build.gradle @@ -34,9 +34,7 @@ android { testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" } lintOptions { - disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' } compileOptions { sourceCompatibility JavaVersion.VERSION_1_8 diff --git a/packages/webview_flutter/webview_flutter_android/android/build.gradle b/packages/webview_flutter/webview_flutter_android/android/build.gradle index f053954e5755..6783e1c977c2 100644 --- a/packages/webview_flutter/webview_flutter_android/android/build.gradle +++ b/packages/webview_flutter/webview_flutter_android/android/build.gradle @@ -30,9 +30,7 @@ android { } lintOptions { - disable 'AndroidGradlePluginVersion' - disable 'InvalidPackage' - disable 'GradleDependency' + disable 'AndroidGradlePluginVersion', 'InvalidPackage', 'GradleDependency' } dependencies {