Skip to content

Contain all page content in landmarks #10543

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
Tracked by #9495 ...
atsansone opened this issue May 8, 2024 · 1 comment
Closed
Tracked by #9495 ...

Contain all page content in landmarks #10543

atsansone opened this issue May 8, 2024 · 1 comment
Assignees
Labels
e2-days Effort: < 5 days infra.accessibility Relates to the accessibility of docs.flutter.dev infra.structure Relates to the tools that create docs.flutter.dev p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@atsansone
Copy link
Contributor

From https://buganizer.corp.google.com/issues/337316892

Observed Results

Navigating through the page, all page content should be contained by landmarks.

Expected Results

Ensures all page content is contained by landmarks

User Impact

Screen reader users are not able to skip to the primary content efficiently and save them time and action presses.

Steps to Reproduce

  1. Enabled ChromeVox using Ctrl + Alt + Z.
  2. Open the following page: https://docs.flutter.dev/
  3. Start the landmark navigation using "search plus ;"
  4. Observe the behavior
  5. Open parashu and run the automatic tool

GAR Assessment

Flutter Docs

GAR Details

2.8. Do you provide a bypass for headings and content that are repeated across multiple pages or within the same page?

Environment Details

Machine: Chromebook / Macbook
Browser: Chrome (123.0.6312.112 (Official Build) (64-bit))
Accessibility Tool: Chromevox / VoiceOver
Bug filling time: 15 mins.

@atsansone atsansone added p2-medium Necessary but not urgent concern. Resolve when possible. t.a11y Relates to an accessibility concern st.triage.ltw infra.structure Relates to the tools that create docs.flutter.dev e2-days Effort: < 5 days labels May 8, 2024
@parlough parlough added infra.accessibility Relates to the accessibility of docs.flutter.dev and removed t.a11y Relates to an accessibility concern labels Mar 12, 2025
@parlough
Copy link
Member

I believe this is resolved by #10531 and other cleanup. The top nav has a banner role, the left and right navs have the navigation role, the footer has contentinfo, and the primary content is in main > article with a skip button to it.

If anyone has more concerns or issues relating to page landmarks, please feel free to reopen or open a new issue. Thanks so much!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
e2-days Effort: < 5 days infra.accessibility Relates to the accessibility of docs.flutter.dev infra.structure Relates to the tools that create docs.flutter.dev p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants