Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updated the platform channels documentation for background isolate channels #7592

Closed
wants to merge 2 commits into from

Conversation

gaaclarke
Copy link
Member

This adds documentation for the new feature that allows us to use plugins and channels from background isolates.

issue: flutter/flutter#13937

Do not land until that feature is on stable.

Presubmit checklist

and platform channels from background isolate.
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once some minor suggestions are addressed

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
@Leedehai
Copy link
Contributor

Hi - any movements on this PR?

@stuartmorgan
Copy link
Contributor

@Leedehai No, per the comment in the PR description:

Do not land until that feature is on stable.

@atsansone
Copy link
Contributor

@gaaclarke : Did this hit stable yet?

@atsansone atsansone added the act.await-dev-pr Needs dev PR to merge before merging docs label Oct 25, 2022
@gaaclarke
Copy link
Member Author

@gaaclarke : Did this hit stable yet?

no, siree

@sfshaza2
Copy link
Contributor

sfshaza2 commented Nov 1, 2022

@gaaclarke, I see that issue flutter/flutter#13937 is closed because it has been fixed on master. Do you know when it will hit stable? I see a few possible approaches:

  • We add a note to the text that this is fixed on master and then remove when it hits stable
  • We add a note that it will be stable in release 3.3.8 (or whatever)
  • We leave this PR as is until it does actually hit stable

I'm not a fan of lingering PRs, but sometimes it's just the way it is.

@gaaclarke
Copy link
Member Author

@gaaclarke, I see that issue flutter/flutter#13937 is closed because it has been fixed on master. Do you know when it will hit stable?

I have a rough idea. I don't know if publicly we've promised a date for the next stable release. It may be later than we were originally expecting. It will be the next stable release though.

I see a few possible approaches:

  • We add a note to the text that this is fixed on master and then remove when it hits stable
  • We add a note that it will be stable in release 3.3.8 (or whatever)
  • We leave this PR as is until it does actually hit stable

I'm not a fan of lingering PRs, but sometimes it's just the way it is.

It isn't bothering me beyond the stress of making sure it doesn't get forgotten. Any of those sounds fine to me, just let me know what works for you. I already am in this predicament because of the medium article I'm sitting on anyways.

@sfshaza2
Copy link
Contributor

sfshaza2 commented Nov 1, 2022

ok, I'll leave this for now. But I'm happy to review your article, @gaaclarke!

@gaaclarke
Copy link
Member Author

ok, I'll leave this for now. But I'm happy to review your article, @gaaclarke!

Thanks shams, it's the one you already reviewed, not a new one =)

@sfshaza2 sfshaza2 added the act.merge-to-next Merge PR to next stable branch release label Dec 5, 2022
@sfshaza2
Copy link
Contributor

closing

@sfshaza2 sfshaza2 closed this Jan 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
act.await-dev-pr Needs dev PR to merge before merging docs act.merge-to-next Merge PR to next stable branch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants