Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix logging for tf.output #649

Closed
chanwit opened this issue Jun 6, 2023 · 3 comments · Fixed by #650
Closed

Fix logging for tf.output #649

chanwit opened this issue Jun 6, 2023 · 3 comments · Fixed by #650
Assignees
@chanwit

Comments

@chanwit
Copy link
Collaborator

chanwit commented Jun 6, 2023 •
edited
Loading

We should wrap tf.Output with logging disabled as well.

outputs, err := r.tf.Output(ctx)

cc @greenu
@chanwit chanwit mentioned this issue Jun 6, 2023
Merged
@chanwit chanwit self-assigned this Jun 6, 2023
@greenu
Copy link

greenu commented Jun 6, 2023

That was superfast! Thanks @chanwit !

@chanwit
Copy link
Collaborator Author

chanwit commented Jun 7, 2023

ping @greenu
could you please help test v0.14.4 to see if it fixed your problem?

@greenu
Copy link

greenu commented Jun 7, 2023

it works! @chanwit
Thank you!

@GoVulnBot GoVulnBot mentioned this issue Jul 14, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@chanwit chanwit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix logging for tf.output flux-iac/tofu-controller
2 participants
@chanwit @greenu