Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for ambassador ingress #142

Open
jdamata opened this issue Apr 10, 2019 · 10 comments
Open

Support for ambassador ingress #142

jdamata opened this issue Apr 10, 2019 · 10 comments
Labels
kind/upstream-blocked Depends on a missing upstream feature

Comments

@jdamata
Copy link

jdamata commented Apr 10, 2019

I think all that is needed is to have ambassador annotations added to the primary service which would direct traffic to both the primary service and canary service based on weight.

https://www.getambassador.io/docs/dev-guide/canary-release-concepts/#flexible-kubernetes-canary-releases-smart-routing-with-ambassador

Ref:
#67
#49

@stefanprodan
Copy link
Member

Does Ambassador have a go client and CRD?

@jdamata
Copy link
Author

jdamata commented Apr 11, 2019

Nope, theres talk of it in emissary-ingress/emissary#482.

@stefanprodan stefanprodan added the kind/upstream-blocked Depends on a missing upstream feature label Apr 12, 2019
@cdbyrd
Copy link

cdbyrd commented May 23, 2019

So thinking about this in a different way, if you have ambassador in front of istio, serving as the API Manager and cluster ingress, the service definition is separate and behind that (no standard ingress controller/gateway and ingress resources). If you did a canary deployment against the service definition, it seems like that would work. You wouldn't need to touch ambassador if you didn't use it for canary definition and just used flagger as that tool to manage istio.

@trash-anger
Copy link

Hi,
Here's an update about ambassador which now have both CRD (datawire/ambassador#482) and and client go.

@RTodorov
Copy link

@stefanprodan can we remove the upstream-blocked label? also, is there a recommendation on how to use flagger to orchestrate canary while having Ambassador as the api-gateway?

@stefanprodan
Copy link
Member

@RTodorov can you point me to the go clientset package?

@ghost
Copy link

ghost commented Aug 19, 2019

@RTodorov Is this something you are looking for? https://github.com/datawire/ambassador/tree/master/go

@jonathanmccracken
Copy link

any progress on supporting Flagger with Ambassador?

@olemarkus
Copy link

I would also be very interested in this

@klemmster
Copy link

Hey there,
is there any update on this?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/upstream-blocked Depends on a missing upstream feature
Projects
None yet
Development

No branches or pull requests

8 participants