Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update Flux components to Kubernetes controller-runtime v0.15 #3907

Closed
7 tasks done
stefanprodan opened this issue May 23, 2023 · 0 comments
Closed
7 tasks done

Update Flux components to Kubernetes controller-runtime v0.15 #3907

stefanprodan opened this issue May 23, 2023 · 0 comments
Assignees
@stefanprodan @hiddeco @aryan9600
Labels
umbrella-issue Umbrella issue for tracking progress of a larger effort

Comments

@stefanprodan
Copy link
Member

stefanprodan commented May 23, 2023 •
edited
Loading

Update the GitOps Toolkit packages and the Flux controllers to Kubernetes 1.27, controller-runtime v0.15 and controller-gen v0.12.

Adapt the controller code to the breaking changes introduced in controller-runtime v0.15:

  • Watches require a plain client.Object instead of a source.Kind object.
  • handler.MapFunc requires a Go context.
  • ctrlcache.Options.SelectorByObject was renamed to ctrlcache.Options.ByObject.
  • ctrl.Options.Namespace was moved to ctrlcache.Options.Namespaces.
  • ctrl.Options.ClientDisableCacheFor was moved to ctrlclient.CacheOptions.DisableFor.
  • ctrl.Options.Port has been deprecated and removed.
  • Fake clients used in tests must be configured using WithStatusSubresource to enable the correct behavior for status updates and patches.

TODOs:

  • fluxcd/pkg (pkg/#534 pkg/#567)
  • source-controller
  • kustomize-controller
  • notification-controller
  • helm-controller
  • image-reflector-controller
  • image-automation-controller
@stefanprodan stefanprodan added the umbrella-issue Umbrella issue for tracking progress of a larger effort label May 23, 2023
@aryan9600 aryan9600 mentioned this issue May 23, 2023
Merged
@stefanprodan stefanprodan mentioned this issue May 23, 2023
Merged
@aryan9600 aryan9600 mentioned this issue May 23, 2023
Merged
This was referenced May 23, 2023
Merged
Merged
@hiddeco hiddeco mentioned this issue May 23, 2023
Merged
This was referenced May 24, 2023
Merged
Closed
@hiddeco hiddeco mentioned this issue May 24, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@stefanprodan stefanprodan

@hiddeco hiddeco

@aryan9600 aryan9600

Labels
umbrella-issue Umbrella issue for tracking progress of a larger effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanprodan @hiddeco @aryan9600