Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add flags to configure exponential back-off retry #363

Closed
pjbgf opened this issue Apr 12, 2022 · 0 comments · Fixed by #399
Closed

Add flags to configure exponential back-off retry #363

pjbgf opened this issue Apr 12, 2022 · 0 comments · Fixed by #399
Labels
good first issue Good for newcomers
Milestone
Bootstrap GA

Comments

@pjbgf
Copy link
Member

pjbgf commented Apr 12, 2022

Two new flags (--min-retry-delay and --max-retry-delay) have been added on fluxcd/pkg/runtime to enable users configuring the exponential back-off retry settings.

Those tags should be brought into notification-controller in a similar way they were implemented in the other controllers:
fluxcd/source-controller#664
fluxcd/image-automation-controller#348

xref: fluxcd/pkg@4046043
@pjbgf pjbgf added the good first issue Good for newcomers label Apr 12, 2022
@pjbgf pjbgf added this to the GA milestone Aug 8, 2022
@pjbgf pjbgf mentioned this issue Aug 9, 2022
Merged
@pjbgf pjbgf moved this to Since Last Dev Meeting in Maintainers' Focus Aug 10, 2022
@pjbgf pjbgf moved this from Since Last Dev Meeting to Done in Maintainers' Focus Aug 11, 2022
@stefanprodan stefanprodan modified the milestones: GA, Bootstrap GA Jul 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Maintainers' Focus
Archived in project
Milestone
Bootstrap GA
Development

Successfully merging a pull request may close this issue.

Add flags to configure exponential back-off retry pjbgf/notification-controller
2 participants
@stefanprodan @pjbgf