Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

The token field should be excluded from the alert payload #650

Closed
Tracked by #4473
stefanprodan opened this issue Nov 23, 2023 · 0 comments · Fixed by #686
Closed
Tracked by #4473

The token field should be excluded from the alert payload #650

stefanprodan opened this issue Nov 23, 2023 · 0 comments · Fixed by #686
Labels
area/alerting Alerting related issues and PRs bug Something isn't working good first issue Good for newcomers

Comments

@stefanprodan
Copy link
Member

In #530 we've added a token field to be used for rate limiting. This field is used internally and should've be part of the payload sent to alert providers.

Screenshot 2023-11-23 at 09 59 41
@stefanprodan stefanprodan added bug Something isn't working area/alerting Alerting related issues and PRs labels Nov 23, 2023
@stefanprodan stefanprodan changed the title The token field should be excluded from the alter payload The token field should be excluded from the alert payload Nov 23, 2023
@makkes makkes added the good first issue Good for newcomers label Nov 28, 2023
@stefanprodan stefanprodan mentioned this issue Dec 13, 2023
Closed
19 tasks
@darkowlzz darkowlzz mentioned this issue Dec 13, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
area/alerting Alerting related issues and PRs bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude eventv1.MetaTokenKey from event metadata fluxcd/notification-controller
2 participants
@makkes @stefanprodan