Source controller creates zero bytes helm chart artifacts

[willejs]

When the default values.yaml file and override valuesFiles in a helm chart match, zero byte tarball artifacts are created.

This manifests itself at the helm controller where you receive an error:

file '/tmp/flux-system-some-service-238100903.tgz' does not appear to be a gzipped archive; got 'application/octet-stream'

It looks like the source controller diffs the two values files, and upon no diff, does not save the chart and writes an empty file.

I thought it was something to do with the logic here, It looks like it uses the goto and fallthrough to the default clause, which just saves the artifact, which is empty?

Anyway, adding something into the override file to make it diff is a workaround.

See: https://cloud-native.slack.com/archives/CLAJ40HV3/p1618843302170000