From 6bf8dc5cca02765c89a92588cbb3260c3de3255a Mon Sep 17 00:00:00 2001 From: Hidde Beydals Date: Thu, 17 Mar 2022 13:13:45 +0100 Subject: [PATCH] api/v1beta2: add note on Condition polarity This was missing for `BuildFailedCondition` and `StorageOperationFailedCondition`. Signed-off-by: Hidde Beydals --- api/v1beta2/condition_types.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/api/v1beta2/condition_types.go b/api/v1beta2/condition_types.go index 2611cf257..647b8aa7f 100644 --- a/api/v1beta2/condition_types.go +++ b/api/v1beta2/condition_types.go @@ -42,14 +42,19 @@ const ( // BuildFailedCondition indicates a transient or persistent build failure // of a Source's Artifact. // If True, the Source can be in an ArtifactOutdatedCondition. + // This is a "negative polarity" or "abnormal-true" type, and is only + // present on the resource if it is True. BuildFailedCondition string = "BuildFailed" // StorageOperationFailedCondition indicates a transient or persistent // failure related to storage. If True, the reconciliation failed while // performing some filesystem operation. + // This is a "negative polarity" or "abnormal-true" type, and is only + // present on the resource if it is True. StorageOperationFailedCondition string = "StorageOperationFailed" ) +// Reasons are provided as utility, and not part of the declarative API. const ( // URLInvalidReason signals that a given Source has an invalid URL. URLInvalidReason string = "URLInvalid"