-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(NavigationFooter): copyright notice, site title #297
Conversation
I see. This would allow to customize it. But it's adding a lot of clutter to the backend UI. And all of that for information that in my opinion doesn't add much value to a website. |
I think placeholder variables nor a shortcode and a plugin are not very comfortable for content managers, because they must remember that functionality. My first idea was to display the copyright notice and the title of the site as simple fallback, only if no content is inserted — the main advantage of this functionality is, that the copyright notice will be shown from scratch, nobody must adjust the year manually. And in company sites, the site title often represents the company name. I‘m still thinking about other ways for implementation, but I’m not sure what is the main target behind to get this feature implemented and which solutions do you prefer. |
I appreciate your effort and thinking. I agree with your point that having to remember shortcodes is an issue. That's why I wouldn't implement it without any other good reasons and solutions that aim to make the experience seamless. |
@steffenbew: I understand your position! We have many customers who want display a copyright notice, so that i think it could be a good starting point to implement it as a feature. I have checked my mind and updated the component again. Hope this is a better way ;) |
@Pixelsaft I have had another look at your revisited solution. I like that you thought about different options. On the other side, I could think of even more options how to format such notice. I don't want to create a seemingly complicated logic and many options for something that has a low impact on the overall site. What I could still imagine is adding a default_value to the wysiwyg, with custom shortcodes: As the available shortcodes are prepopulated, a content manager knows their options. Additionally, the available shortcodes could be listed in the field The shortcodes could be defined in a new file: I took the following article as a reference: https://divimundo.com/en/blog/copyright-year-wordpress-footer/ What do you think? |
Adjustment according to feedback (#297 (comment))
@steffenbew all good ones are three – just updated according to your feedback. |
Thanks for the update, @Pixelsaft. Looking great! The shortcode examples are also very helpful! I would like to suggest the following changes:
On another note, the tab content appears twice in the WordPress backend for me. Is it just me? Can't spot anything wrong with the code. |
@steffenbew according to your feedback we made some changes.
On another note, the tab content appears twice in the WordPress backend for me. Is it just me? Can't spot anything wrong with the code. > I can’t reproduce this error – I think it’s just you. |
@Pixelsaft Thanks for the changes!
|
@steffenbew: It would be able for a content manager to remove the copyright notice, now.
We have added a new Tab "Options" with two switches at the "Translatable Options" from the NavigationFooter (this is not 100% consistent but the Component "Grid Posts Archive" has also an "Options" tab to setup at this area.