Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Windows Dynamic Resize #299

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Fix Windows Dynamic Resize #299

merged 1 commit into from
Aug 18, 2020

Conversation

harunbleech
Copy link
Contributor

No description provided.

@harunbleech harunbleech requested a review from domtra August 18, 2020 10:00
@domtra
Copy link
Member

domtra commented Aug 18, 2020

@harunbleech, great. thank you.
generally i try to avoid using these kind of str_replaces.
do you think you can achieve the same thing with using realpath() on $homePath and $uploadDir['basedir']?

@harunbleech
Copy link
Contributor Author

@domtra using realpath() give us \wp-content\uploads. Then we would need to remove this first backslash. The rewrite rule will work but it will look like this ^wp-content\uploads/resized/?(.*?)/?$

@harunbleech
Copy link
Contributor Author

@domtra get_home_path() does the same at the end return str_replace( '\\', '/', $home_path );

Copy link
Member

@domtra domtra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright @harunbleech. thanks for the info.

@harunbleech harunbleech merged commit 789098e into master Aug 18, 2020
@harunbleech harunbleech deleted the windowsDynamicResize branch August 18, 2020 14:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants