Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Housekeeping] Flytectl cross compilation issue #1082

Closed
yindia opened this issue May 31, 2021 · 1 comment
Closed

[Housekeeping] Flytectl cross compilation issue #1082

yindia opened this issue May 31, 2021 · 1 comment
Assignees
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Milestone

Comments

@yindia
Copy link
Contributor

yindia commented May 31, 2021

Describe the Issue
After adding go-graphviz, the flytectl build starts failing because of a cross-compilation issue. This is a known issue.

More detail:

  1. Unable to build binary for project with a dependency on go-graphviz goccy/go-graphviz#43
  2. Crossbuilding with xgo goreleaser/goreleaser#708

Ref: flyteorg/flytectl#76

How to fix this
Community created an example of cross-compilation using docker https://goreleaser.com/cookbooks/cgo-and-crosscompiling/

Ref:

  1. https://github.com/troian/golang-cross (we can fork the implementation from here)
  2. https://github.com/troian/golang-cross-example (Example for goreleaser)
  3. https://github.com/elastic/golang-crossbuild

What if we do not do this?
For implementing go-graphviz in flytectl, we need to resolve it or else we are not able to add graph functionality.

Related component
flytectl

@yindia yindia added the housekeeping Issues that help maintain flyte and keep it tech-debt free label May 31, 2021
@yindia
Copy link
Contributor Author

yindia commented May 31, 2021

CC: @kumare3 @EngHabu @pmahindrakar-oss

@yindia yindia self-assigned this Jun 3, 2021
@yindia yindia added this to the 0.15.0 milestone Jun 3, 2021
@yindia yindia closed this as completed Jun 11, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

No branches or pull requests

1 participant