Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

An ignored/excluded file, still gets added to the graph when edited and saved #480

Closed
ribeirompl opened this issue Feb 7, 2021 · 4 comments
Labels
bug Something isn't working foam-core Related to API, core model or feature
Milestone

Comments

@ribeirompl
Copy link

ribeirompl commented Feb 7, 2021

  • Foam version: v0.9.1
  • Platform: Linux
  • Issue occur on the foam template repo: No

Summary
Within .vscode/settings.json, I added the following line:
"foam.files.ignore": ["readme.md"]

I reloaded vscode, and that file no longer was on the graph, as expected.
However when I made a change to the readme and then saved the file, foam added the file back onto the graph.
Only after reloading vscode, did the file no longer appear on the graph. However, editing the readme would add it back.

So it appears that when a markdown file is saved, that the graph does not check the ignore list, before updating itself?

Steps to reproduce

  1. Clone the foam template repo (although any foam notes repo should work).
  2. Confirm that readme.md appears on the graph. For the foam-template repo, it is named "Foam" on the graph.
  3. Add "foam.files.ignore": ["readme.md"] to settings.json.
  4. Note, that closing and reopening the graph, does not remove the readme file.
  5. Reload vscode, and confirm that the readme now does not appear on the graph.
  6. Edit readme.md, and save the file.
  7. Look at the graph to see the readme appear (even though it should be ignored).
@ribeirompl ribeirompl added the bug Something isn't working label Feb 7, 2021
@riccardoferretti riccardoferretti added the foam-core Related to API, core model or feature label Feb 11, 2021
@sbussard
Copy link

sbussard commented Mar 2, 2022

+1

@riccardoferretti riccardoferretti modified the milestones: backlog, 1.0.0 Mar 2, 2022
@riccardoferretti
Copy link
Collaborator

Fixed in 0.17.8

@pallavbakshi
Copy link

The issue still exists.

@riccardoferretti
Copy link
Collaborator

@pallavbakshi I can't reproduce it following the steps above, can you please create a new issue with the steps to reproduce the problem?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working foam-core Related to API, core model or feature
Projects
None yet
Development

No branches or pull requests

4 participants