Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

How to pass "destinationPredefinedAcl" to copy_object? #505

Closed
yosiat opened this issue Sep 28, 2020 · 1 comment
Closed

How to pass "destinationPredefinedAcl" to copy_object? #505

yosiat opened this issue Sep 28, 2020 · 1 comment

Comments

@yosiat
Copy link
Contributor

yosiat commented Sep 28, 2020

Hi,

I am trying a bug in my code, where I copy an object and it loses it's publicRead permission when doing the copy.
From the google docs, looks like I need to pass destinationPredefinedAcl with publicRead and this should fix my issue.

But looks like fog-google is not supporting this:
https://github.com/fog/fog-google/blob/master/lib/fog/storage/google_json/requests/copy_object.rb
https://github.com/googleapis/google-api-ruby-client/blob/master/generated/google/apis/storage_v1/service.rb#L1743

I can submit a PR to allow this, but I am not sure how the API should like it, except adding another parameter like settings and splat it into copy_object but this is a breaking API that it's not supported in XML request (or other fog libraries).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant