Update syntax highlighting colors #3017
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/savq/Pluto.jl", rev="theme")
julia> using Pluto |
- Replace `--cm-color-[atom|property]` with `--cm-color-symbol`. Use a bolder typeface for properties. - Replace `--cm-color-number` with `--cm-color-literal`. Highlight booleans, characters, and numbers as literal. - Rename `--cm-color-var` to `--cm-color-variable`
fonsp
reviewed
Jan 20, 2025
| --cm-color-literal: #8e5189; | ||
| --cm-filter-type: brightness(150%) saturate(50%);; | ||
|
|
||
| /* The colors below are not used in CellInput.js */ |
There was a problem hiding this comment.
can you update this comment? if they are not used then why have them?
There was a problem hiding this comment.
They're not used in CellInput.js, but some are used in things like highlightjs.css.
I'll try to refactor the highlightjs stuff before removing them.
|
hey sergio! i'd like to make a release soon, if you want this to be included can you finish the PR or merge a subset of it? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--cm-color-[atom|property]with--cm-color-symbol.Use a bolder typeface for properties.
--cm-color-numberwith--cm-color-literal.Highlight booleans, characters, and numbers as literal.
--cm-color-varto-variable.Closes #2921