Database consistency

[lentschi]

The current foodsoft DB has multiple db inconsistencies (broken foreign keys mainly).

I've made an attempt to address the issue by adding foreign key constraints, however this PR is now long since deprecated. (We've never gotten around to merging it.)

However, in the light of the extend article units PR and of the issue found by RayOei we might think about having another go at this before merging the PR. (This would of course be quite some effort as the PR would then need to update and extend those constraints)

Any thoughts?

[RayOei]

Technically I am in favour of getting the database sorted out, it is one of the things that hurt my eyes, so to speak. But I would also consider it another scope creep which will postpone this large PR once again, making it even more complex.

So: yes we should do it. But NOT with this PR.

Better to have a focused task for improving the structure/constraints/cascade update & delete etc. as this will undoubtedly unveil all kinds of issues.
Another option is to add improving parts of the database when working on a specific feature, which that feature touches?

[lentschi]

But I would also consider it another scope creep which will postpone this large PR once again, making it even more complex.

Yes, of course that's the downside, which is why we had decided to leave it out initially.

But on the other hand, it would then be easier to identify which db inconsistencies were caused by the migrations in the article units fork (I hope none, but you never know) and which had been in there before.

I personally still lean towards postponing it as you suggest - I just wanted everybody's opinion first.

[RayOei]

As to the mentioned issue #1114, see comment: #1114 (comment)