Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix financial_transactions controller to respond with 422 for invalid params #999

Closed
yksflip opened this issue May 10, 2023 · 0 comments
Closed
Milestone

Comments

@yksflip
Copy link
Member

yksflip commented May 10, 2023

this is a follow up for a bug discovered in #969

      # TODO: fix controller to actually send a 422 for invalid params?
      # Expected response code '200' to match '422'
      # Response body: {"financial_transaction":{"id":316,"user_id":599,"user_name":"Lisbeth ","amount":-3.0,"note":"-2","created_at":"2022-12-12T13:05:32.000+01:00","financial_transaction_type_id":346,"financial_transaction_type_name":"aut est iste #9"}}
      #
      # response '422', 'invalid parameter value' do
      #   # schema '$ref' => '#/components/schemas/Error422'
      #   let(:financial_transaction) { { amount: -3, financial_transaction_type_id: create(:financial_transaction_type).id, note: -2 } }
      #   run_test!
@yksflip yksflip moved this to Prioritised in Foodsoft roadmap May 12, 2023
@yksflip yksflip moved this from Prioritised to Next Release in Foodsoft roadmap Jun 9, 2023
@yksflip yksflip added this to the 4.8 milestone Jun 9, 2023
@github-project-automation github-project-automation bot moved this from Next Release to Done in Foodsoft roadmap Jun 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant