From 084e352e053b5939de4c63e515615d0332a692d3 Mon Sep 17 00:00:00 2001
From: Laurent Demailly <ldemailly@gmail.com>
Date: Tue, 13 Feb 2024 15:03:02 -0800
Subject: [PATCH] add comment/question about readiness

---
 mstore/dnsWatch.go | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mstore/dnsWatch.go b/mstore/dnsWatch.go
index 4993bbc..57a0b41 100644
--- a/mstore/dnsWatch.go
+++ b/mstore/dnsWatch.go
@@ -29,6 +29,9 @@ var (
 func reverseDNS(ips sets.Set[string]) (sets.Set[string], bool) {
 	allNames := sets.Set[string]{}
 	hasError := false
+	// From observation (hopefully true across kubernetes/coredns implementaions): any error
+	// means "in progress" so we wait until there are no errors (might be an issue though
+	// once we add readiness probe).
 	for ip := range ips {
 		names, err := net.LookupAddr(ip)
 		if err != nil {