Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Extend sort_index interface to allow int32 index argument #822

Closed
Beliavsky opened this issue May 21, 2024 · 1 comment · Fixed by #829
Closed

Extend sort_index interface to allow int32 index argument #822

Beliavsky opened this issue May 21, 2024 · 1 comment · Fixed by #829

Comments

@Beliavsky
Copy link

The index argument of sort_index has type int64. I suggest that the sort_index interface be extended so that an index argument of type int32 is also supported. I understand that int64 was chosen to accommodate very large arrays, but it in most cases int32 is sufficient, and many programmers use default integers. The current interface trips people up, for example here and here.

@jvdp1
Copy link
Member

jvdp1 commented May 21, 2024

thank you @Beliavsky for the heads up. Indeed, having both version could be useful.
I will have a look.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants