Switch from the shortcut.js to the jquery.hotkeys.js library. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original shortcut.js library has trouble handling special keys. For example, if a shortcut for 't' is defined, pressing F5 will trigger it because the keycode for F5 is equal to the charcode for 't' (116).
SSilence
added a commit
that referenced
this pull request
Mar 14, 2013
Switch from the shortcut.js to the jquery.hotkeys.js library.
|
Thanks a lot for the pull request. I also planed to switch to jquery hotkeys because the used library is old and there exists no support. |
|
Hi @Sigill. Previously, it was not clear if selfoss was licensed under GPL 3 only, or also any later version. Could you clarify whether you are fine with licensing your contributions here and in other PRs under Thanks again and sorry for the confusion. |
|
I agree with licensing my contributions to selfoss under GPL-3-or-later. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original shortcut.js library has trouble handling special keys.
For example, if a shortcut for 't' is defined, pressing F5 will
trigger it because the keycode for F5 is equal to the charcode for
't' (116).
See for example branch
throw_shortcuts_shortcut.jsin git://github.com/Sigill/selfoss.git.Switching to the jquery.hotkeys.js seemed to me a better option than patching the shortcut.js library.