-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Convert Icons to SVG #296
Comments
In Android in order to use .png, .jpg or any other bitmap resources we need to put it inside drawable directory |
@mariobehling also all the images which can be converted to svg are already converted |
@mariobehling @iamareebjamal Please Close this, all the possible icons are already in svg |
@iamareebjamal are you sure, the size wont increase?. The reason they are not converted is because if I do, there size may increase from bytes to kilobytes |
Also, representing such simple icons will not take much size. And if it does, then something is wrong. png for this low resolution will have smaller size but it will not be scalable and consume a lot more than vector file in higher resolutions. Also, it makes it easier to edit later |
@iamareebjamal the size of the images is currently in bytes. If you shift them to xml, it will increase rather decreasing. Just tested it out. Also the badge requires no longer than 40x11 images, we can scale them perfectly fine in the app right now as well, as they are monochromatic and symmetric |
All the more reason to make them SVG
Doesn't matter, they are binary, unchangeable and non scalable. If I want to edit them, those bytes will be added to the repo again. In SVG, only changes I do as text will be stored Not every issue is a discussion. This has to be done |
Got it |
Since Android 5 it is possible to use SVGs in Android. They are automatically converted to PNGs if necessary in Android Studio. Using SVGs will stop us worrying about resolutions and make it easier to keep the image quality high. Please change the icons to SVGs.
Reference: https://android.jlelse.eu/stop-using-your-svg-as-png-87b5edd367cd
The text was updated successfully, but these errors were encountered: