Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement back and forth animation #892

Open
mariobehling opened this issue Jan 2, 2024 · 2 comments
Open

Implement back and forth animation #892

mariobehling opened this issue Jan 2, 2024 · 2 comments
Assignees

Comments

@mariobehling
Copy link
Member

mariobehling commented Jan 2, 2024

The Python version has a back and forth animation.

Please implement the same here

bicycle

This option should be part of the animation screen (middle option).
Screenshot from 2024-02-26 11-27-33

@amrsalah3
Copy link
Contributor

According to BadgeBLE, the device only supports 8 types of animations that are already included in BadgeMagic Android app. The python version implements this back-and-forth animation by sending 2 messages to the device: One message sliding to the left then the same but sliding to the right (and repeat).

However, the android version doesn't support sending more than 1 message (Please checkSendingUtils.kt):

fun convertToDeviceDataModel(message: Message): DataToSend {
        return DataToSend(listOf(message))
 }  

Therefore, we need first to modify the project to support accepting a list of messages, not only 1 message. After that, we can implement this back-and-forth animation easily.

@amrsalah3
Copy link
Contributor

#644

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants