Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Increased code #238

Closed
abishekvashok opened this issue Dec 6, 2016 · 4 comments
Closed

Increased code #238

abishekvashok opened this issue Dec 6, 2016 · 4 comments
Assignees

Comments

@abishekvashok
Copy link
Member

abishekvashok commented Dec 6, 2016

The code on index.html is huge and can be optimised a lot. The slider can be loaded via Jekyll as well as the logos of MBDyn can be loaded dynamically via Jekyll.

It will definitely improve code quality and reduce quantity, making it easier for debugging.

It can be implemented easily by making changes in the index.html file.

@hemantjadon
Copy link
Contributor

Want to take this up @Abhi2424shek ?

Also you will have to make sure that you will touch only the necessary parts of the code otherwise all the future PR's will get conflicts.

@PolBaladas
Copy link
Member

Good idea @Abhi2424shek indeed, but be careful with merge conflicts.

@abishekvashok
Copy link
Member Author

@hemantjadon I take it on.

@abishekvashok
Copy link
Member Author

abishekvashok commented Dec 6, 2016

See the PR: #244 @hemantjadon @niccokunzmann after it's merged we could close it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants