Skip to content

replace anvil DepositTransaction with just op_alloy::TxDeposit #10475

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
mattsse opened this issue May 8, 2025 · 1 comment · May be fixed by #10480
Open

replace anvil DepositTransaction with just op_alloy::TxDeposit #10475

mattsse opened this issue May 8, 2025 · 1 comment · May be fixed by #10480
Assignees
Labels
C-anvil Command: anvil T-debt Type: code debt

Comments

@mattsse
Copy link
Member

mattsse commented May 8, 2025

Component

Anvil

Describe the feature you would like

these are the same types pratically:

impl From<DepositTransaction> for TxDeposit {

we can remove the DepositTransaction entirely and instead just use TxDeposit

TODO

  • remove entire optimism.rs file
  • update usage within anvil, e.g. breaking function calls, missing trait imports, make it compile

maybe @Rimeeeeee :) since you already worked on alloy-rs/op-alloy#514

Additional context

No response

@mattsse mattsse added T-debt Type: code debt C-anvil Command: anvil labels May 8, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Foundry May 8, 2025
@Rimeeeeee
Copy link
Contributor

Will do :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-anvil Command: anvil T-debt Type: code debt
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants