Skip to content

feat(forge): invariant tests instrumentation with function call summaries #4186

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
PaulRBerg opened this issue Jan 26, 2023 · 3 comments
Closed
Labels
T-feature Type: feature

Comments

@PaulRBerg
Copy link
Contributor

PaulRBerg commented Jan 26, 2023

Component

Forge

Describe the feature you would like

It would be useful to get a report of the distribution of function calls at the end of a successful invariant test run.

Users currently have to resort to manually instrumenting the function calls by adding storage vars, which clutters the handler contracts with logic that is unrelated to the actual business logic of the protocol. See, for example, the numCalls mapping defined in Lucas' invariant-examples repo, and also his invariant_call_summary function.

This is something that should be done by Forge, which is in charge of orchestrating the invariant tests anyway.

@PaulRBerg PaulRBerg added the T-feature Type: feature label Jan 26, 2023
@PaulRBerg
Copy link
Contributor Author

If you like this idea, @mds1, should we add it to your todo list in #3412?

@mds1
Copy link
Collaborator

mds1 commented Jan 26, 2023

Duplicate of #3607? (which is already tracked in #3412)

@PaulRBerg
Copy link
Contributor Author

I missed that issue! Sorry, closing.

@PaulRBerg PaulRBerg closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
T-feature Type: feature
Projects
None yet
Development

No branches or pull requests

2 participants