feat(cast): add contract creation bytecodes to traces #8941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeSandwich
requested review from
DaniPopes,
klkvr and
mattsse
as code owners
|
You need to use nightly to format code 'cargo +nightly fmt' |
|
It works as expected, thanks! It's actually even pointed out in |
DaniPopes
approved these changes
Sep 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #8906.
Solution
Prints the contract creation bytecodes in the trace when
--verboseis passed tocast run.I'm not sure if there are tests for this parts of the code, so I haven't added or changed any.
Formatting was a big mystery to me, I did my best manually, but I don't understand what's the correct approach. I haven't found any guide in
.mdfiles, but there is arustfmt.tomlfile and the code seems formatted, but runningcargo fmtalters dozens of files across the whole project, which apparently are not automatically formatted.