-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: more fixes for --all-features tests #8946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, that makes sense
one suggestion
if let Some(signal) = handle.shutdown_signal_mut().take() { | ||
signal.fire().unwrap(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we convert this to a function on handle?
and document why we call this for some tests
@@ -205,6 +205,7 @@ forgetest_init!(can_override_config, |prj, cmd| { | |||
); | |||
|
|||
// env vars work | |||
std::env::remove_var("DAPP_REMAPPINGS"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should just not be using env vars in cli tests, it can only work if its set on a spawned command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, will clean those tests and move such remapping test in dedicated
Motivation
more fixes for
cargo test --all --all-features
clean runverify_bytecode
tests, fixingDAPP_REMAPPINGS
env var fromcan_override_config
test, fixingSolution