Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: add comments for alloy-core patches #8955

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

DaniPopes
Copy link
Member

Happens often enough that we should keep the patches commented out. This was also done for ethers since there's a lot of crates and they generally all must be patched together or it won't compile.

Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@DaniPopes DaniPopes merged commit 883bb1c into master Sep 24, 2024
21 checks passed
@DaniPopes DaniPopes deleted the dani/alloy-core-patches branch September 24, 2024 18:48
rplusq pushed a commit to rplusq/foundry that referenced this pull request Sep 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants