New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

direShell calling quit is evil: instead should throw a (sub)class of CatcheableError #63

Open

timotheecour opened this issue Oct 11, 2018 · 0 comments

timotheecour commented Oct 11, 2018 •

edited

Loading

/cc @yglukhov @fowlmouth

see also https://forum.nim-lang.org/t/4042#25152: (quit considered evil: bypasses defer and try/catch/finally which might do important cleanups)

eg in $nim_D/nimx/nimx/naketools.nim it prevents doing things like:

try:
  direShell "xcodebuild", "-project", xcodeProjDir/"SDL.xcodeproj", "-target", "Static\\ Library", "-configuration", "Release", "-sdk", "macosx"&b.macOSSDKVersion, "SYMROOT=build"
except CatchableError as e:
  # process e, give an informative msg (eg to suggest alternatives like brew install sdl2), or provide fallback options

The text was updated successfully, but these errors were encountered:

# for free to join this conversation on GitHub. Already have an account? # to comment