Skip to content
This repository has been archived by the owner on Jan 10, 2019. It is now read-only.

Garnet regression errors #30

Open
agitter opened this issue Feb 17, 2018 · 4 comments
Open

Garnet regression errors #30

agitter opened this issue Feb 17, 2018 · 4 comments

Comments

@agitter
Copy link
Contributor

agitter commented Feb 17, 2018

When testing #29, I noticed that our Garnet integration tests fail with newer versions of SciPy and NumPy. There is a divide by 0 error during the linear regression. We should either explore why that happens or catch the error more gracefully.

@sgosline
Copy link

sgosline commented Feb 17, 2018

Do you have some code/data that reproduces this error?

@agitter
Copy link
Contributor Author

agitter commented Feb 17, 2018

Our Garnet test case can reproduce the error on recent SciPy and NumPy versions. This runs Garnet on the FOXA1 ChIP data in the a549 example directory and confirms that the output files match what we expect. The error comes from motif_regression.py, so we should be able to test directly on that call using the input files events_to_genes_with_motifs.pkl from tests/integration_test_standard/ and Tgfb_exp.txt from the example directory.

The Travis build logs in #29 show some SciPy and NumPy versions that cause the error.

  • SciPy 1.0.0 and NumPy 1.14.0 failed.
  • SciPy 0.19.1 and NumPy 1.14.0 failed.
  • SciPy 0.19.1 and NumPy 1.13.3 worked.

@AmandaKedaigle
Copy link
Contributor

I believe I ran into this problem before - I'll see if I can figure out what I did back then to get around it. (it might just have been changing/updating numpy). But definitely agree we should catch the error

@sgosline
Copy link

sgosline commented Nov 5, 2018

Just checking on this too - I'm just getting a warning, not an error. But I haven't run all the tests. We should maybe just update the docs - we don't support Python 3.x at all either, because of the print statements.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants