Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Installation of wasm-opt fails #329

Closed
shivshankardayal opened this issue Jul 11, 2024 · 4 comments
Closed

Installation of wasm-opt fails #329

shivshankardayal opened this issue Jul 11, 2024 · 4 comments
Labels
A-cli Area: command line interface C-bug Category: bug tribble-reported This issue was reported through Tribble.

Comments

@shivshankardayal
Copy link

This issue is reporting a bug in the code of Perseus. Details of the scope will be available in issue labels.
The author described their issue as follows:

perseus serve -w fails with wasm-opt installtion.

The steps to reproduce this issue are as follows:

  📥 Installing external tools...❌
Error: couldn't extract 'wasm-opt' (do you have the necessary permissions?)

Caused by:
        failed to iterate over archive
        Caused by:
                unexpected end of file

is the output when I try to run perseus serve -w

A minimum reproducible example is available at .

  • Hydration-related: false
  • The author is willing to attempt a fix: false
Tribble internal data

dHJpYmJsZS1yZXBvcnRlZCxDLWJ1ZyxBLWNsaQ==

@github-actions github-actions bot added A-cli Area: command line interface C-bug Category: bug tribble-reported This issue was reported through Tribble. labels Jul 11, 2024
@arctic-hen7
Copy link
Member

Hmm, this looks like something that might arise if your internet connection suddenly dropped out? Has this happened more than once?

@shivshankardayal
Copy link
Author

Yes, it is repeating. I would have tried like 20 times but it never works.

@arctic-hen7
Copy link
Member

Looks like the latest version of wasm-opt has been incorrectly packaged and the GitHub API doesn't know its version. Working on a fix now. In the meantime, use perseus --wasm-opt-version version_118 <rest-of-command>. You should only need to do this once, after that it should be cached, though if the problem comes up again try that.

@arctic-hen7 arctic-hen7 pinned this issue Jul 19, 2024
@arctic-hen7 arctic-hen7 changed the title perserus fails to install wasm-opt Installation of wasm-opt fails Jul 19, 2024
@arctic-hen7
Copy link
Member

Fixed this in the latest commit, will wait for tests to pass and then cut a new release ASAP, thanks for opening an issue on this! (Very easy to miss these: Actions caching means tool installations only get tested sometimes I think, and otherwise they stay cached, so only new users spot these!)

For reference: fix was to use tag_name in GitHub's releases API rather than name (which apparently doesn't get set sometimes).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-cli Area: command line interface C-bug Category: bug tribble-reported This issue was reported through Tribble.
Projects
None yet
Development

No branches or pull requests

2 participants