Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop requirement for zendframework/zend-diactoros #12

Closed
shadowhand opened this issue May 8, 2020 · 4 comments
Closed

Drop requirement for zendframework/zend-diactoros #12

shadowhand opened this issue May 8, 2020 · 4 comments

Comments

@shadowhand
Copy link

There's no need for this requirement. I am using Slim and already have a PSR-7 implementation.

@franzliedke
Copy link
Owner

So you're proposing to adopt PSR-17 factories, I assume?

I'm currently using Diactoros here:

return new HtmlResponse(
$response,
500,
['Content-Type' => $format->getPreferredContentType()]
);

@shadowhand
Copy link
Author

shadowhand commented May 14, 2020

Yes, PSR-15 factories would be a good solution.

@raghuveer
Copy link

raghuveer commented Sep 6, 2020

using PSR-7 Diactoros library is good, I too use that, but I would request you to replace zendframework/zend-diactoros with laminas/laminas-diactoros instead in the composer based dependencies list.

Coming to PSR-15 library, laminas/laminas-stratigility is good like many other PSR-15 Dispatchers.

thank you

@franzliedke
Copy link
Owner

This has been done with #13 or, more precisely, commit 71d75c5.

@shadowhand Please let me know whether this change does the trick for you. Released as version 2.0. Happy new year! 😃

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants