Fix(textAngularSetup): bug #1223 InsertImage tool failed on Firefox only. Firefox would insert into the <a> following a link!

 This also will fix the same issue with InsertVideo - not reported.

Author: JoelParke

src/textAngularSetup.js

@@ -731,6 +731,13 @@ angular.module('textAngularSetup', [])
 			var imageLink;
 			imageLink = $window.prompt(taTranslations.insertImage.dialogPrompt, 'http://');
 			if(imageLink && imageLink !== '' && imageLink !== 'http://'){
+				/* istanbul ignore next: don't know how to test this... since it needs a dialogPrompt */
+				if (taSelection.getSelectionElement().tagName.toLowerCase() === 'a') {
+					// due to differences in implementation between FireFox and Chrome, we must move the
+					// insertion point past the <a> element, otherwise FireFox inserts inside the <a>
+					// With this change, both FireFox and Chrome behave the same way!
+					taSelection.setSelectionAfterElement(taSelection.getSelectionElement());
+				}
 				return this.$editor().wrapSelection('insertImage', imageLink, true);
 			}
 		},
@@ -757,6 +764,13 @@ angular.module('textAngularSetup', [])
 					// for all options see: http://stackoverflow.com/questions/2068344/how-do-i-get-a-youtube-video-thumbnail-from-the-youtube-api
 					// maxresdefault.jpg seems to be undefined on some.
 					var embed = '<img class="ta-insert-video" src="https://img.youtube.com/vi/' + videoId + '/hqdefault.jpg" ta-insert-video="' + urlLink + '" contenteditable="false" allowfullscreen="true" frameborder="0" />';
+					/* istanbul ignore next: don't know how to test this... since it needs a dialogPrompt */
+					if (taSelection.getSelectionElement().tagName.toLowerCase() === 'a') {
+						// due to differences in implementation between FireFox and Chrome, we must move the
+						// insertion point past the <a> element, otherwise FireFox inserts inside the <a>
+						// With this change, both FireFox and Chrome behave the same way!
+						taSelection.setSelectionAfterElement(taSelection.getSelectionElement());
+					}
 					// insert
 					return this.$editor().wrapSelection('insertHTML', embed, true);
 				}