Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

"Handle overlay" isn't refreshed after windows resize #1326

Closed
fts-mage opened this issue Sep 19, 2016 · 3 comments
Closed

"Handle overlay" isn't refreshed after windows resize #1326

fts-mage opened this issue Sep 19, 2016 · 3 comments
Labels
bug

Comments

@fts-mage
Copy link

Click on an image display an overlay that don't refreshed after window resizing.
@JoelParke
Copy link
Collaborator

JoelParke commented Sep 20, 2016 •
edited
Loading

I assume that what you see is something like:

screenshot from 2016-09-20 09-52-06

Which is a bit of an issue, but when would you want to resize the window when you were resizing the image inside? Since there a bunch of other bugs on the plate to fix first.

Is this what you are thinking about?

@fts-mage
Copy link
Author

For example (in Windows) by pane-right the editor window and pane-left an informative doc. Or by using tablet or other modern device able to change orientation. The editor will be used in email builder that allow user to build email on pc/tablet and phone (?). that's why i have to check how editor will react in those cases.

But, indeed, user can reclick the picture to see perfect overlay :)

JoelParke added a commit to JoelParke/textAngular that referenced this issue Oct 2, 2016
@JoelParke
fix(main): corrected the no reflowPopover() when window resized or sc…
f9715de 
…rolled. Issue: textAngular#1326

 - main.js added:
    - scope.handlePopoverEvents()
    - isScrollable() helper function
    - enhanced scope.getScrollTop() to now add an event listener when
      it is scrollable.
    - added scope._scrollListener();
 - test/textAngular.spec - ensure no error on getScrollTop()
@JoelParke JoelParke mentioned this issue Oct 2, 2016
Merged
@JoelParke
Copy link
Collaborator

This is corrected with PR #1350. Please test. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fts-mage @JoelParke