Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

One letter TLD should be invalid #56

Closed
marijam26 opened this issue Jun 18, 2024 · 5 comments
Closed

One letter TLD should be invalid #56

marijam26 opened this issue Jun 18, 2024 · 5 comments

Comments

@marijam26
Copy link

I'm using your dependency for validating email address in my flutter project and for values like 'example@gmail.c' or 'example-@gmail.com' validate function is returning 'true' like it's valid value and it should return false.

@fredeil
Copy link
Owner

fredeil commented Jun 18, 2024

I cannot see why example-@gmail.com shouldn't be valid. The discussion about 1 letter TLD has been up for discussion ,as it's allowed by the spec but not really used. I might fix that one. Thanks for reporting

@fredeil fredeil closed this as completed Jun 18, 2024
@fredeil
Copy link
Owner

fredeil commented Jun 18, 2024

I've added fix for 1 letter TLD 98972bc

@fredeil fredeil changed the title Invalid email input is returning valid One letter TLD should be invalid Jun 21, 2024
@pankaj-nikam
Copy link

Hi @fredeil , just a point of view, what about someone@x.com should it validate since x.com is a proper domain?

@fredeil
Copy link
Owner

fredeil commented Jun 23, 2024

That still works @pankaj-nikam. TLD = .com / .net / .org etc.

@pankaj-nikam
Copy link

Got it. Thanks 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants