-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Modify code to use a generic underline json value #71
Comments
I have a question. What do you mean by custom struct? |
I mean that the json structure (in memory) is not a I imagine we can define a trait such that each object that wants to be jsonpath "compatible" will need to implement this trait (for sure the implementation for serde_json::Value will come built-in). The trait can define functions like For existing users, the API will stay exactly the same, but it will open a door for more users to be able to use this library. WDYT? |
I didn't understand exactly. Can I understand as below? let v = TestStruct { ... };
let result = jsonpath::select(&v, "$.name").unwrap(); |
Yes, exactly. |
That's a good idea. Thanks in advance for the PR. 👍 |
Maybe this trait could be useful to add (and retrieve) other metadata to the json node structure, such as the reference to the parent node or to the key string of the node. For instance I submitted a PR (#84) that implements the parent operator by the mean of a |
Today the code assumes the underline json structure is serde_json::Value. We have a situation where this is not the case and we need to work with a custom structure. We still want to use this library with our structure. I was wondering if you will accept a PR that changes the code to work with any value that implement a defined trait, this way it can be use with serde_json::Value but with other structures as well. If you agree we can use this issue to define the details and I will be happy to contribute the PR.
The text was updated successfully, but these errors were encountered: