Skip to content
This repository has been archived by the owner on Apr 15, 2023. It is now read-only.

Use native GitHub release generator #53

Closed
fregante opened this issue Dec 17, 2021 · 2 comments
Closed

Use native GitHub release generator #53

fregante opened this issue Dec 17, 2021 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@fregante
Copy link
Owner

This would be a big change, but I think it makes sense (especially because it would save us from release notes generation bugs and further requests).

The v3 of this action and the underlying generator can be forked as they're released under MIT.

Such change would let us drop most of the current code and replace it with: https://github.com/MylesBorins/node-osc/blob/v6.1.11/.github/workflows/create-release.yml#L26-L41

The native generator can be configured separately from this action as well, so most options except title, draft and prerelease can be dropped as well.

It would close:

Context:

@mdirshaddev

This comment was marked as off-topic.

@fregante
Copy link
Owner Author

fregante commented Oct 16, 2022

It looks like this whole action can be replaced by a single gh-cli line:

I'm contemplating turning the action into a "composite action", which accepts a couple of inputs (like assets) and then calls gh-cli

Or potentially just deprecate and archive the action, which is easier. The advantage of wrapping the CLI in an action is that it would allow slightly easier configuration, e.g.:

  • automatically picking the latest tag
  • automatically zipping any folders

It may be worth it, but also I don’t think I'd want to maintain this action further for extremely minimal savings.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants