-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
The list of ta-lib indicators used in the strategies #54
Comments
Details on appearances:
|
For Finta, only |
I don't think we need to replace talib from the strategies repository to satisfy freqtrade/freqtrade#2509. We need to remove it from Default / Sample Strategy - and from here "where possible" - maybe. |
Than it should be added as dependency here. The custom version with the patch... |
I'm not sure i understand what you'd patch ... |
The patch to ta-lib, which is required for cryptos due to low asset price values, |
ah that patch ... - sorry - it wasn't really clear. we'll also need to keep it in freqtrade (imho) itself - removing ta-lib from the docker image will risk breaking peoples running strategies ... which is ... bad . . . |
it's easier to keep it in the docker (because it's build in a more predeterminated environment and conditions) than to keep it a general dependency... |
I think TA modules need to be included in docker images. Some of the strats won't run without them. |
The main TA modules (ta-lib, technical) are included in the docker images. There's literally 100ds of others out there - if you need one of these, you can use the docker dependency instruction to include them in your docker image. |
This will help select a replacement library to move to from ta-lib.
$ egrep -roh 'ta\..*\(' .|sort -u
gives
Total number of appearances to be changed:
The text was updated successfully, but these errors were encountered: