Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add flags to include/exclude specific features #4

Open
cuviper opened this issue May 26, 2020 · 3 comments
Open

Add flags to include/exclude specific features #4

cuviper opened this issue May 26, 2020 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cuviper
Copy link

cuviper commented May 26, 2020

In crates where I'm supporting older Rust versions, it's frequently the case that some of the features will only work on more recent Rust. So in order to use cargo all-features, I would need a way to list which features are actually expected to work for the Rust that I'm currently testing.

Another case is that many crates have features like "unstable" that would only be expected to work when using a nightly toolchain. That would need to be excluded when testing all stable features.

@frewsxcv frewsxcv added the enhancement New feature or request label May 26, 2020
@frewsxcv frewsxcv added the help wanted Extra attention is needed label Jun 13, 2020
@frewsxcv
Copy link
Owner

Sounds good to me. I won't be able to get to this, so if someone wants to work on it, go ahead! Once you open a PR, I can review + merge + release

@Person-93
Copy link
Contributor

Sounds good to me. I won't be able to get to this, so if someone wants to work on it, go ahead! Once you open a PR, I can review + merge + release

You said here that you want to keep the flags the same as cargo, so maybe something like this?
cargo all-features <ALL_FEATURES_ARGUMENTS> [-- <CARGO_ARGUMENTS>]
Or this?
cargo all-features <CARGO_COMMAND> [ALL_FEATURES_ARGUMENTS] [-- <CARGO_ARGUMENTS>]

@demmerichs
Copy link
Contributor

I think this issue can be closed as at least some configurability through Cargo.toml is given. More explicit feature requests should be covered in a new issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants