Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

Remove deprecated navigation bar setting #1364

Merged
merged 2 commits into from
Apr 18, 2016

Conversation

dungpa
Copy link
Contributor

@dungpa dungpa commented Apr 15, 2016

The setting has been deprecated from Visual F# tools.

Close #1295.

dungpa added 2 commits April 15, 2016 15:09
The setting has been deprecated from Visual F# tools.
@vasily-kirichenko
Copy link
Contributor

So no navigation bar anymore?..

@smoothdeveloper
Copy link
Contributor

@dungpa, I still see the navbar in my VS2015, what is up with removing it from settings? is it enabled by default in Visual F# tooling?

@dungpa
Copy link
Contributor Author

dungpa commented Apr 15, 2016

In Visual F# tools vNext, it will be either be available via Roslyn-based API or be removed completely. Either way, it's no longer Ok to check for the setting to enable the feature anymore.

The toggle for Navigation Bar in VFPT has never fully worked. I'm really happy when we can finally remove it.

@vasily-kirichenko vasily-kirichenko merged commit f9e648c into fsprojects-archive:master Apr 18, 2016
@dungpa dungpa deleted the remove-nav-bar branch April 18, 2016 12:12
@jackfoxy
Copy link

Somehow the nav bar is mysteriously working in one of my 3 environment. All 3 environment are VS 2015 update 2 F#PT 2.4.0.

Go figure.

I personally would like this feature to remain as long as possible. Just because it is deprecated does not mean it does not still work. The fact it is still working in one of my environment is evidence of that. I'm not sure what the definition of "never fully worked" is. I do know it would appear/disappear with new PT releases sometimes. Still, it was worth the trouble for me. It's not like it cause VS to crash (at least I don't think it did).

@dsyme
Copy link
Contributor

dsyme commented Apr 25, 2016

The code from the Visual F# Tools is here: https://github.com/Microsoft/visualfsharp/blob/master/vsintegration/src/FSharp.LanguageService/NavigationBar.fs plus some C# code too in FSharp.LanguageService.Base

Maybe it could just be moved into VFPT.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants