Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

View metadata when Peek Definitions on external assemblies #1369

Merged
merged 7 commits into from
Apr 22, 2016

Conversation

dungpa
Copy link
Contributor

@dungpa dungpa commented Apr 21, 2016

Close #1314.

Refactor Navigate to Metadata feature in order to enable Peek Definition.

I haven't tested with VS 2015 so far; just ensure that Go to Definition stills work as is.

@vasily-kirichenko Could you help test Peek Definitions on VS 2015 on external assemblies?

@vasily-kirichenko
Copy link
Contributor

Add reference to Microsoft.VisualStudio.Shell.12.0 in VS2015 project.

@vasily-kirichenko
Copy link
Contributor

When I press Alt+F12, VS 2015 freezes indefinitely. The UI thread stack trace:

image

If I click on this icon:

image

It unfreezes and the peek definition window appears:

image

Also System.Guid.fsi file is open in VS (as a separate normal view). While it's open Alt+F12 works perfectly for Guid, once it's closed, the issue is back.

@dungpa
Copy link
Contributor Author

dungpa commented Apr 21, 2016

@vasily-kirichenko Done. Could you give it a try?

@vasily-kirichenko
Copy link
Contributor

Works perfectly.

@vasily-kirichenko
Copy link
Contributor

Great job!

@vasily-kirichenko vasily-kirichenko merged commit ac4fd90 into fsprojects-archive:master Apr 22, 2016
@dungpa dungpa deleted the metadata branch April 22, 2016 07:13
@dungpa
Copy link
Contributor Author

dungpa commented Apr 22, 2016

Thanks.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants