-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
change compression to compressor in netCDF.3.translate zarr.create_dataset calls #535
base: main
Are you sure you want to change the base?
change compression to compressor in netCDF.3.translate zarr.create_dataset calls #535
Conversation
This is right, but I don't understand why no one hit it before! Is it possible to add a test in https://github.com/fsspec/kerchunk/blob/main/tests/test_netcdf.py which would have failed, but with this change passes? |
@martindurant I'll see if I can update the netcdf unit tests to capture this behavior. |
@martindurant It looks like
You'll see that I am using the kerchunk conda package. I have not specified the Zarr in this test environment, so Zarr 3.0.0 is installed by default. |
I think this should be fixed in the latest release, which now only supports zarr3. |
Replaces 'compression
with correct
compressor`argument in netCDF3.translate zarr.create_dataset calls.Fixes #534
Tested with python 3.12 and kerchunk v.0.2.7 on RHEL8 OS