Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: RSA key configuration and more #2

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

camphillips22
Copy link
Collaborator

@camphillips22 camphillips22 commented Sep 11, 2024

Description

Adds the ability to configure an RSA key for the snowflake user. Also adds the ability to configure the names for the resources in case the user wants to use a specific naming scheme.

Issue or Ticket

https://fullstory.atlassian.net/browse/ACT-960

Checklist before submitting PR for review

  • This change requires a doc update, and I've included it
  • My code follows the style guidelines of this project
  • I have ensured my code is commented and any new terraform variables have proper descriptions

@camphillips22 camphillips22 changed the title RSA key configuration and more feat: RSA key configuration and more Sep 13, 2024
@camphillips22 camphillips22 force-pushed the cam/configure-rsa-key branch 2 times, most recently from 60d851c to c724014 Compare September 13, 2024 13:19
Adds the ability to configure an RSA key for the snowflake user.
Also adds the ability to configure the names for the resources in case the user
wants to use a specific naming scheme.
Copy link
Contributor

@huttotw huttotw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


## Inputs

| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_database_name"></a> [database\_name](#input\_database\_name) | The name of the Snowflake database to use | `string` | n/a | yes |
| <a name="input_fullstory_cidr_ipv4"></a> [fullstory\_cidr\_ipv4](#input\_fullstory\_cidr\_ipv4) | The CIDR block that Fullstory will use to connect to the Redshift cluster. | `string` | `""` | no |
| <a name="input_disable_password"></a> [disable\_password](#input\_disable\_password) | Whether to disable the password for the Snowflake user. If true, the user will only be able to authenticate using the RSA public key. | `bool` | `false` | no |
| <a name="input_fullstory_cidr_ipv4"></a> [fullstory\_cidr\_ipv4](#input\_fullstory\_cidr\_ipv4) | The CIDR block that Fullstory will use to connect to Snowflake. | `string` | `""` | no |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops

outputs.tf Outdated Show resolved Hide resolved
@camphillips22 camphillips22 merged commit 6d574f8 into main Sep 25, 2024
9 checks passed
@camphillips22 camphillips22 deleted the cam/configure-rsa-key branch September 25, 2024 17:27
@camphillips22
Copy link
Collaborator Author

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants