Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace DEFAULT_LAST_N in plotting with integer default + add % support #162

Closed
baggiponte opened this issue Jan 7, 2024 · 1 comment
Closed

Replace DEFAULT_LAST_N in plotting with integer default + add % support #162

baggiponte opened this issue Jan 7, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers plotting Plotting features
Milestone
0.9.X

Comments

@baggiponte
Copy link
Collaborator

DEFAULT_LAST_N as default value is comfy but ugly for the end user: from the docs it's not clear what the default is.

  1. Add float support: if 0.1 -> plot 10% of the series
  2. Add an heuristic to plot e.g. 10% if it has < 1000 points, 5% if < 10_000 else 1%.
@baggiponte baggiponte self-assigned this Jan 7, 2024
@baggiponte baggiponte added the good first issue Good for newcomers label Jan 7, 2024
@baggiponte baggiponte removed their assignment Jan 7, 2024
@baggiponte baggiponte added this to the 0.10 milestone Jan 7, 2024
@baggiponte baggiponte added plotting Plotting features enhancement New feature or request labels Jan 7, 2024
@baggiponte
Copy link
Collaborator Author

Last PR #235 partly addressed this. No weird logics for defaults. Will create a separate issue for % support.

@baggiponte baggiponte modified the milestones: 0.10, 0.9.X Jun 9, 2024
@baggiponte baggiponte mentioned this issue Jun 9, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers plotting Plotting features
Projects
None yet
Milestone
0.9.X
Development

No branches or pull requests
1 participant
@baggiponte