Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EddystoneUID with only 18 datalength #3

Closed
EwaRvr opened this issue Jul 13, 2018 · 2 comments
Closed

EddystoneUID with only 18 datalength #3

EwaRvr opened this issue Jul 13, 2018 · 2 comments

Comments

@EwaRvr
Copy link

EwaRvr commented Jul 13, 2018

I am using Kontakt.IO beacons in Eddystone UID setting, however, those beacons only include 18 characters of data.
As nowhere in the code you use the last 2 digits, in file lib/parser-eddystone.js would you be opposed to changing line 82 to if(data.length !== 20 && data.length !== 18) {?

Also, I would love to see the ability to pass in a parameter into the scanner to enable the return of any non-supported beacon formats from the parser (similar to https://github.com/cagdasakar/mechanic-ble-scanner/blob/master/lib/parser.js, just turned on by a parameter for backwards compatibility.
It would have helped me tremendously with discovering the above issue, as I would have been able to see the tags come through unparsed, rather than just being absent.

I can create a pull request for both if you like?

@futomi
Copy link
Owner

futomi commented Jul 14, 2018

Thank you so much for your feedback. As you reported, I found that the size of the Eddystone-UID packet from Kontakt device is 18 bytes. I updated the node-beacon-scanner. Try the latest version.

@EwaRvr
Copy link
Author

EwaRvr commented Jul 16, 2018

Great! thank you!

@EwaRvr EwaRvr closed this as completed Jul 16, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants