You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
At the moment different providers expose middle names in different ways.
For example, person provider for ru_RU locale exposes middle names with two methods: middleNameMale and middleNameFemale. At the same time, person provider for vi_VN locale exposes middle names as a single middleName method.
I suggest to use only one way of exposing middle names. To be compatible with lastName and firstName it should be done as in vi_VN locale with a single method middleName with $gender flag.
If the maintainer is interested in it I could provide a PR to fix this.
The text was updated successfully, but these errors were encountered:
Consider an use case when the lib is used to generate test data for multilingual system. If I use both ru_RU and vi_VN locales for testing I have to vary method name to get middle name. For example:
$faker = \Faker\Factory::create('ru_RU');
$faker->firstName(\Faker\Provider::GENDER_MALE);
$faker->middleNameMale(); // There is no "middleName" method with "gender" argument :(
At the moment different providers expose middle names in different ways.
For example, person provider for
ru_RU
locale exposes middle names with two methods:middleNameMale
andmiddleNameFemale
. At the same time, person provider forvi_VN
locale exposes middle names as a singlemiddleName
method.I suggest to use only one way of exposing middle names. To be compatible with
lastName
andfirstName
it should be done as invi_VN
locale with a single methodmiddleName
with$gender
flag.If the maintainer is interested in it I could provide a PR to fix this.
The text was updated successfully, but these errors were encountered: